Improve options#148
Merged
Merged
Conversation
…or CoRB option - Consolidate logic for checking System properties and CoRB options and looking for normalized keys in both Snake_Case and Kebab-Case in a convenience method Options.findOption. - Ensure that MAX-OPTS-FROM-MODULE works if specified as original name MAX_OPTS_FROM_MODULE - updated README.md with consistent formatting and language for option default values
Codecov Report
@@ Coverage Diff @@
## development #148 +/- ##
=================================================
+ Coverage 83.65% 83.70% +0.04%
- Complexity 1295 1298 +3
=================================================
Files 45 46 +1
Lines 4204 4209 +5
Branches 630 629 -1
=================================================
+ Hits 3517 3523 +6
Misses 461 461
+ Partials 226 225 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xcc.httpcompliant, if not explicitly set as System property or CoRB option