Repository navigation
fix: isolate extension names from Object.prototype - #4177
Merged
UziTech merged 1 commit intoNov 2, 2026
Merged
Conversation
|
@minjungsung is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
styfle
approved these changes
Nov 2, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 2, 2026
## [18.1.3](v18.1.2...v18.1.3) (2026-11-02) ### Bug Fixes * allow trailing tabs after a setext heading underline ([#4152](#4152)) ([1f1b480](1f1b480)) * avoid quadratic scan for unmatched emphasis delimiters ([#4103](#4103)) ([eab1e48](eab1e48)), closes [#4099](#4099) * await promise arrays from walkTokens extensions ([#4153](#4153)) ([c38704c](c38704c)) * **cli:** honor defaults and config when outputting tokens ([#4146](#4146)) ([9470e8f](9470e8f)) * collapse internal whitespace when normalizing link labels ([#4157](#4157)) ([02c73e8](02c73e8)) * do not allow a blank line inside a link reference definition label ([#4165](#4165)) ([f3d21af](f3d21af)) * don't treat an escaped ) or quote as an inline link or title closer ([#4151](#4151)) ([9cb84e0](9cb84e0)) * end a list item before a lazy line after an html block ([#4159](#4159)) ([7ba42f4](7ba42f4)) * end blockquote before a lazy line after a table ([#4161](#4161)) ([e7dcf52](e7dcf52)) * isolate extension names from Object.prototype ([#4177](#4177)) ([5cb03bd](5cb03bd)) * keep a block quote open after a lazy line in a nested block quote ([#4175](#4175)) ([1d7272f](1d7272f)) * only close a code fence with the opening fence character ([#4164](#4164)) ([1d4d8fe](1d4d8fe)) * preserve zero-valued custom renderer results ([#4162](#4162)) ([e43ceef](e43ceef)) * recognize task list items when a tab follows the checkbox ([#4163](#4163)) ([64a299d](64a299d)) * start a GFM www autolink only at a word boundary ([#4166](#4166)) ([84beefb](84beefb)) ### Performance Improvements * fix backtracking in padantic html ([#4173](#4173)) ([2d4a23c](2d4a23c))
This was referenced Nov 6, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version: 18.1.2 /
8babc79Markdown flavor: n/a (extension API)
Description
Custom extension names such as
constructor,toString, and__proto__collide with inherited properties in the renderer and child-token registries. WithwalkTokensenabled, parsing an otherwise valid custom token throwsthis.defaults.extensions.childTokens[genericToken.type].forEach is not a function. A renderer returningfalsecan also call an inherited Object function, producing[object Object]or throwing instead of using registered renderer behavior.Initialize both registries with
Object.create(null), as already done for link definitions. This changes registry initialization only and adds no checks to the parsing or token-walking loops. Existing extension chaining stays intact.Expectation
This extension should render
exampleand visit its token:Result
On the current master, this throws during token walking. The online demo filters out extension and walkTokens callbacks, so the runnable JavaScript above reproduces the API issue. Input preview shows the ordinary Markdown input without the custom extension.
Validation
npm testpasses on Node 26.12.1: 1,947 spec tests and 228 unit tests, including builds, module checks, type checks, and ESLint.git diff --checkpasses.Contributor
Committer
AI disclosure: Codex (GPT-6) discovered and reproduced the issue, prepared the code, tests, and this description, and ran the checks above. No human review is claimed.