Repository navigation
fix: await promise arrays from walkTokens extensions - #4153
Merged
UziTech merged 2 commits intoNov 2, 2026
Merged
Conversation
|
@Plastic-time is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Plastic-time
marked this pull request as ready for review
October 22, 2026 01:59
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 2, 2026
## [18.1.3](v18.1.2...v18.1.3) (2026-11-02) ### Bug Fixes * allow trailing tabs after a setext heading underline ([#4152](#4152)) ([1f1b480](1f1b480)) * avoid quadratic scan for unmatched emphasis delimiters ([#4103](#4103)) ([eab1e48](eab1e48)), closes [#4099](#4099) * await promise arrays from walkTokens extensions ([#4153](#4153)) ([c38704c](c38704c)) * **cli:** honor defaults and config when outputting tokens ([#4146](#4146)) ([9470e8f](9470e8f)) * collapse internal whitespace when normalizing link labels ([#4157](#4157)) ([02c73e8](02c73e8)) * do not allow a blank line inside a link reference definition label ([#4165](#4165)) ([f3d21af](f3d21af)) * don't treat an escaped ) or quote as an inline link or title closer ([#4151](#4151)) ([9cb84e0](9cb84e0)) * end a list item before a lazy line after an html block ([#4159](#4159)) ([7ba42f4](7ba42f4)) * end blockquote before a lazy line after a table ([#4161](#4161)) ([e7dcf52](e7dcf52)) * isolate extension names from Object.prototype ([#4177](#4177)) ([5cb03bd](5cb03bd)) * keep a block quote open after a lazy line in a nested block quote ([#4175](#4175)) ([1d7272f](1d7272f)) * only close a code fence with the opening fence character ([#4164](#4164)) ([1d4d8fe](1d4d8fe)) * preserve zero-valued custom renderer results ([#4162](#4162)) ([e43ceef](e43ceef)) * recognize task list items when a tab follows the checkbox ([#4163](#4163)) ([64a299d](64a299d)) * start a GFM www autolink only at a word boundary ([#4166](#4166)) ([84beefb](84beefb)) ### Performance Improvements * fix backtracking in padantic html ([#4173](#4173)) ([2d4a23c](2d4a23c))
This was referenced Nov 6, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version: 18.1.1 / current master
Markdown flavor: n/a (extension API)
walkTokenscallbacks may return an array of promises. When registered withmarked.use(), that array is currently wrapped in another array, so the async parse path'sPromise.all()does not await its promises. For example, a callback returning[fetchData().then(() => updateToken(token))]can leave the rendered output unchanged even afterawait marked.parse(...).Use the existing
pushValueshelper when collecting the newly registered callback's return value, matching how earlier callbacks and traversal results are collected. This retains callback order and the existing linear-time accumulation. Update the public extension callback type to accept the existing array return contract and compile a regression against the public declarations.Validation on Windows / Node 24.20.0:
parse, andparseInline.npm testpassed: build/docs, specification tests, unit tests, UMD/CJS checks, type checks, and lint.Contributor
AI disclosure: Codex (GPT-6) assisted with investigation, implementation, tests, and this description. Prepared for maintainer review.
Readiness verification — 2026-10-22 UTC
Verified commit
781b3f6be57349318b199d98cd1085412f6dd26eagainst the current upstream diff and contribution guidance. No unresolved review threads or merge conflicts were present at this check.npm testpassed on Windows / Node 24.20.0, including clean build/docs, 1911 spec tests, 201 unit tests, UMD/CJS checks, declaration/package checks and lint. The current head includes the publicMarkedExtension.walkTokensarray return type and a public-declaration compile test, in addition to the runtime fix. No additional source changes were needed; the checkout remains clean.git diff --checkpasses. Local verification is separate from upstream CI. The upstream workflow still requires maintainer approval; it has not been counted as a successful run.