Always suffix indented code block with a newline#799
Merged
rlidwka merged 1 commit intomarkdown-it:masterfrom Jul 15, 2021
Merged
Always suffix indented code block with a newline#799rlidwka merged 1 commit intomarkdown-it:masterfrom
rlidwka merged 1 commit intomarkdown-it:masterfrom
Conversation
Member
|
Merged, thanks! Is code block the only place where the absense of trailing newline in original input matters? |
Contributor
Author
This I don't have an answer to right now, I haven't tested. I found this issue while fuzzing mdformat and if there are other similar issues with other syntax then the fuzzer should find them when I have the time to get back into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
codeblock\n(where
\nrepresents a trailing newline) renders differently tocodeblock(no trailing newline).
The former renders to
and the latter to
This PR makes the two examples render to the same HTML by always adding a trailing newline to code block content.
The spec is not overly clear about this corner case, but this PR makes