Fix compatibility with latest builder release #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It removed `BlankSlate`. So, just use `BasicObject` which has been available for more than decade now
Contributor
|
Thanks for the PR! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jun 15, 2024
0.9.4 (2024-06-14) * Earlopain - Fix compatibility with latest builder release #49 * github.com/markaby/markaby/pull/49 * Aesthetikx Add Missing HTML5 Tags #48 - github.com/markaby/markaby/pull/48 * MrPowers - Small Refactorings - github.com/markaby/markaby/pull/50, github.com/markaby/markaby/pull/34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It removed
BlankSlate. So, just useBasicObjectwhich has been available for more than decade now.This is already what was happening behind the scenes: https://github.com/rails/builder/pull/15/files#diff-94d48985e142bdb522d4d25ab7bf82493317da39f15f646feb04d6b9bc5ffb83L18
Note that I still have two test failures but they happen both with and without this change.