Fix Mac OS compilation#328
Merged
Merged
Conversation
arvanus
reviewed
Oct 3, 2023
|
|
||
| //! Do not instantiate objects of this class. Use config() function (see below). | ||
|
|
||
| #if defined(__UNIX__) && !defined(__WXMAC_OSX__) |
Collaborator
There was a problem hiding this comment.
isn't WXMAC_OSX directive used anymore?
Thank you
Contributor
Author
|
on my MacbookPro (Mac OS 13 and 14) it did not match
It looks outdated may be for Carbon Mac
…On Tue, Oct 3, 2023 at 4:13 PM arvanus ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/config/Config.h
<#328 (comment)>:
> @@ -44,7 +44,7 @@ class wxFileConfig;
//! Do not instantiate objects of this class. Use config() function (see below).
-#if defined(__UNIX__) && !defined(__WXMAC_OSX__)
isn't *WXMAC_OSX* directive used anymore?
Thank you
—
Reply to this email directly, view it on GitHub
<#328 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADITO7S4D5AG445VF7572VLX5QFNXAVCNFSM6AAAAAA5Q65PROVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJVGE4DGNRUHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
|
So could you adjust to keep this older directive too? |
Collaborator
|
Don't know if we have users using this OS |
Contributor
Author
|
With the release of macOS 10.15 Catalina, the Carbon API was officially
discontinued and removed, leaving Cocoa as the sole primary API for
developing macOS applications. Apple Inc.
Current Mac OS version is 14.0
…On Tue, Oct 3, 2023 at 4:46 PM arvanus ***@***.***> wrote:
Don't know if we have users using this OS
—
Reply to this email directly, view it on GitHub
<#328 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADITO7SVNGJMOMSIBSRHCSDX5QJJ3AVCNFSM6AAAAAA5Q65PROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBVGAYTGMRTG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.