Skip to content

Add support for update or insert#271

Merged
mariuz merged 1 commit into
mariuz:devfrom
Jdochoa:94
Aug 26, 2022
Merged

Add support for update or insert#271
mariuz merged 1 commit into
mariuz:devfrom
Jdochoa:94

Conversation

@Jdochoa

@Jdochoa Jdochoa commented Aug 26, 2022

Copy link
Copy Markdown
Contributor

Add support for update or insert #94

Update Insert

@mariuz
mariuz merged commit 5b85264 into mariuz:dev Aug 26, 2022
@arvanus

arvanus commented Aug 28, 2022

Copy link
Copy Markdown
Collaborator

@Jdochoa could you take a look that it's repeating the insert or update SQL N times, where N=total records - current position
Also if you select more than 1 row, it gets strange

@arvanus

arvanus commented Aug 28, 2022

Copy link
Copy Markdown
Collaborator

Suggestion, remove the matching part or verify if the selected part has the PK part, if not them omit the patch part. But be aware that you could use another fields to match, or even another unique key (so it's simpler to remove/ignore the matching part)

@Jdochoa

Jdochoa commented Aug 28, 2022

Copy link
Copy Markdown
Contributor Author

Hi @arvanus
Please review my last commit en dev branch.

./jo

@arvanus

arvanus commented Aug 29, 2022

Copy link
Copy Markdown
Collaborator

working fine on dev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants