FB Library Search#261
Merged
Merged
Conversation
arvanus
reviewed
Jun 20, 2022
|
|
||
| label_charset = new wxStaticText(getControlsPanel(), -1, _("Charset:")); | ||
| long comboStyle = wxCB_DROPDOWN; | ||
| #ifndef __WXMAC__ |
Collaborator
There was a problem hiding this comment.
@Jdochoa do you remember why this change? (just curious because looks like a type
Contributor
Author
There was a problem hiding this comment.
Sorry, it was my mistake. I already corrected it
arvanus
reviewed
Jun 20, 2022
arvanus
approved these changes
Jun 25, 2022
Closed
Collaborator
|
@Jdochoa I think you need to separate this config, one path for x64 and other for x86 build, and this should be transparent for the user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added configuration for FB client library.
At the moment the configuration applies only to windows and at the application level. Connection level implementation pending.
The search order of the library is corrected, remaining as follows:
4.1. Try to locate %FB Directory%\fbclient.dll
4.2.- Try to locate %FB Directory%\wow64\fbclient.dll
4.3.- Try to locate %FB Directory%\bin\fbclient.dll
4.4.- Try to locate %FB Directory%\bin\wow64\fbclient.dll
5.- Let's try from the PATH and System directories for FBClient.dll
6.- Last try : attemps loading gds32.dll from PATH and System directories
Fix: #199 #229 #251 #258