Repository navigation
Linter: Fix false positive for to_s in actionview-no-implicit-polymorphic-url - #2813
Merged
Merged
Conversation
…morphic-url` `isModelReaderCall` treated `ticket.view_url.to_s` as a model reader, so the hint named `to_s_path`. `to_s` and `to_str` return a String, which `url_for` leaves unchanged. The rule now skips those two calls. A `view_url` call without that conversion stays silent. The new cases expect no offense for `ticket.view_url.to_s` and `ticket.view_url.to_str`.
github-actions
Bot
added
linter
devtechedge
changed the title
to_s in actionview-no-implicit-polymorphic-url
Contributor
Author
|
Thank you for merging this, Marco. I appreciate the quick turnaround on the false positive. The to_s and to_str cases are covered in the rule tests now. Happy to follow up if you would like that handled differently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2802