#3601 Always use SourceParameterCondition when checking source parameter #3620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce parameter This is a breaking change, with this change whenever a source parameter is used as a source for a target property the condition has to apply to source parameters and not properties
These work as expected because the `isNotEmpty` presence checks is having a source parameter passed. If we change the parameter with the other the method will be invoked again
thunderhook
approved these changes
Jul 7, 2024
Contributor
thunderhook
left a comment
thunderhook
left a comment
There was a problem hiding this comment.
Just a few optional "expression" nitpicks in the changelog.
As we already said, we can definitely remove some tests, especially those you mentioned as duplicate scenarios in #3601 (comment)
Nevertheless, i will already approve, the current status could also be merged from my side.
Member
Author
|
Thanks @thunderhook. I've applied the proposed changes in the changelog. I also decided to remove all the fixture tests, they were not needed. The main thing that we are testing is already covered by the test that I added. Hope that's OK with you |
Contributor
|
That's totally fine, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, with this change whenever a source parameter is used as a source for a target property the condition has to apply to source parameters and not properties
Fixes #3601