-
-
Notifications
You must be signed in to change notification settings - Fork 1k
#3609 Add test case for issue 3609 #3615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Obolrom do you already have some ideas about the bug fix or do you need me to have a look at it as well? |
|
@filiphr, I am trying to figure out how to fix the bug properly. private Map<String, Accessor> unprocessedConstructorProperties;
private Map<String, Accessor> unprocessedTargetProperties;
private Map<String, Accessor> unprocessedSourceProperties;
private Set<String> missingIgnoredSourceProperties;in the My first attempt to fix it led to 200 failed tests. So, I would appreciate any hint |
|
@Obolrom, I believe that it is somewhere in the |
|
@Obolrom did my hint help you out a bit? If not, I'll take over and do the fix. |
|
@filiphr by some reason it doesn't work anyway. Could you please take a look? |
6776fc6 to
880c93c
Compare
processor/src/main/java/org/mapstruct/ap/internal/model/source/BeanMappingOptions.java
Outdated
Show resolved
Hide resolved
processor/src/main/java/org/mapstruct/ap/internal/model/source/BeanMappingOptions.java
Outdated
Show resolved
Hide resolved
|
Thanks @Obolrom and @thunderhook for working on this. @thunderhook I was not too happy with the fix. I changed it a bit. Have a look at how it looks like, I prefer when things are a bit more explicit than having something special in the generic method. @Obolrom, I reduced the test case a bit to only cover what the actual bug is and reduce the complexity of it. |
Fixes #3609