Skip to content

Conversation

@Zegveld
Copy link
Contributor

@Zegveld Zegveld commented Apr 27, 2024

fixes #3577

@Zegveld Zegveld changed the title Feature/3577 #3577 ignoreByDefault shouldn't affect the specified mapping endpoint. Apr 27, 2024
@filiphr
Copy link
Member

filiphr commented Apr 28, 2024

@Zegveld I've already added a comment (#3577 (comment)). I do not agree with this change. The @BeanMapping is propagated to downstream mapping methods. If you want to customize something then you should define the explicit mapping for what you are trying to map and define the mapping there.

The entire idea of the ignoreByDefault is that you have to provide all the mappings yourself and you want to disable the implicit mapping that MapStruct provides. If you want things partially then you'll have to provide your own custom mapping method for that.

@Zegveld
Copy link
Contributor Author

Zegveld commented Apr 28, 2024

leaving this PR open, and continuing the discussion in the thread.

@Zegveld Zegveld changed the title #3577 ignoreByDefault shouldn't affect the specified mapping endpoint. #3577 improve ignoreByDefault documentation. Apr 28, 2024
@filiphr filiphr merged commit 5fbd36c into mapstruct:main Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify that Mapping#ignoreByDefault is inherited in nested mappings in documentation

2 participants