Skip to content

#3296: skip default methods when determining prototype methods. #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
filiphr merged 3 commits into from
Jul 8, 2023
Merged

#3296: skip default methods when determining prototype methods. #3297

filiphr merged 3 commits into from
Jul 8, 2023

Conversation

@Zegveld
Copy link
Contributor

@Zegveld Zegveld commented Jun 1, 2023

closes #3296

filiphr
filiphr approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@filiphr filiphr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps we should also ignore static methods?

@Zegveld
Copy link
Contributor Author

Zegveld commented Jun 24, 2023

LGTM. Perhaps we should also ignore static methods?

good point, adding that situation as well to this PR. Since that also causes the same error.

@filiphr filiphr merged commit 04434af into mapstruct:main Jul 8, 2023
@filiphr
Copy link
Member

filiphr commented Jul 8, 2023

Thanks @Zegveld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filiphr filiphr filiphr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ignore default and static methods in @MapperConfig

2 participants

@Zegveld @filiphr