#3126 Apply target this references in the BeanMappingMethod #3281
+137
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zegveld
approved these changes
May 24, 2023
Contributor
Zegveld
left a comment
Zegveld
left a comment
There was a problem hiding this comment.
This is indeed a lot better then my solution.
Looks good to me.
Member
Author
|
Thanks for the review @Zegveld |
|
@filiphr thanks for the fix! Is it available in |
Member
Author
|
@nickpnmrv you can check by looking at the fix version for the #3126 issue. The fix is not yet released. It will be in 1.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3126