#3165: support for array to collection with adder preferred #3166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This fix looks OK. However, there are tests missing. If you would like for us to accept this PR please provide tests. By the way the support is not really linked to protobuf. It is rather linked to not being able to map an array to a collection / iterable using an adder. It would be good to add tests like that (not with protobuf). |
eroznik
force-pushed
the
3165/protobuff-array-to-list
branch
from
667c2ce to
fb8de95
Compare
eroznik
changed the title
Contributor
Author
|
@filiphr i've just added a test case for the issue, lmk if thats what you expected.. (: |
filiphr
reviewed
Apr 22, 2023
Member
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
The test you added is good. Would be nice if you can also add a test where the source is Iterable<String>. I think that it won't work without the changes I am mentioning in the comments
processor/src/main/java/org/mapstruct/ap/internal/model/assignment/AdderWrapper.java
Show resolved
Hide resolved
processor/src/main/java/org/mapstruct/ap/internal/model/common/SourceRHS.java
Show resolved
Hide resolved
Member
Contributor
Author
|
Added test case for iterable mapping + the required code changes so the test passes |
Member
|
Thanks @eroznik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offers a potential fix for the problem that I described in #3165 .
Fixes #3165
Fixes #3129