Pass spi namespaced processor options to custom spi #3070
Conversation
ro0sterjam
force-pushed
the
pass-namespaced-processor-options-to-custom-spi
branch
from
d73d729 to
0cb2a88
Compare
|
@ro0sterjam have a look at my comments in #3071 |
|
@filiphr thank you for your guidance. Can you take a look at my changes and let me know what you think? If it looks good I'll proceed with updating the documentation. |
|
Added docs and test |
|
Bump on this. |
|
Thanks for your work on this @ro0sterjam. There is no need to do a bump. We are working on this in our free time and we don't always have time to speedily review it. The PR will be part of the 1.6 release and we'll review it soon. |
|
Thanks @filiphr, completely understood and apologies for the bump. |
|
@ro0sterjam I did some small polishing. Can you please check it out and let me know if you agree with it? If yes then I will resolve the conflict and merge it manually (unless you want to resolve the conflict and force push to your branch) |
|
Looked over the changes and no objections from me! Good idea about supporting multiple |
|
This has been integrated into main. Thanks @ro0sterjam |
2 participants
Currently we are unable to configure custom mapstruct spi implementations because the compilerArg options are not passed down to the spi classes.
This PR exposes these options to
MapStructProcessingEnvironment. I've limited it to only options under the namespace ofmapstruct.ap.spi.to limit the exposure of unrelated options.Fixes #3071