Skip to content

Conversation

@Zegveld
Copy link
Contributor

@Zegveld Zegveld commented Oct 25, 2022

If an object contains an object of the same type a new mapping is currently being created. This is not needed unless it is for subclassmappings.

Fixes #3057

Copy link
Member

@filiphr filiphr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @Zegveld.

I've pushed some small polishing commits, mostly around naming and how things are ordered in the classes. Feel free to merge

@Zegveld Zegveld merged commit 8894cd5 into mapstruct:main Nov 4, 2022
@Zegveld Zegveld deleted the feature/3057 branch November 4, 2022 13:21
filiphr added a commit that referenced this pull request Nov 5, 2022
* #3057: limit do not allow self to subclassmappings.
* #3057: determine method candidates after all other fields are set in the constructor.

Co-authored-by: Ben Zegveld <[email protected]>
Co-authored-by: Filip Hrisafov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 1.5.3 doesn't consider Mapping annotations for nested objects (worked with 1.5.2)

2 participants