Skip to content

#3040 fix: Cannot use only BeanMapping#mappingControl #3045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
filiphr merged 3 commits into from
Nov 3, 2022
Merged

#3040 fix: Cannot use only BeanMapping#mappingControl #3045

filiphr merged 3 commits into from
Nov 3, 2022

Conversation

@chenzijia12300
Copy link
Contributor

@chenzijia12300 chenzijia12300 commented Oct 2, 2022

fix: #3040

@filiphr
Copy link
Member

filiphr commented Oct 2, 2022

This looks good @chenzijia12300. However, regarding the tests, I would rather change DeepCloneMethodMapper and remove the nullValueMappingStrategy from that @BeanMapping. It is not needed in there anyways.

@filiphr filiphr merged commit bb099a5 into mapstruct:main Nov 3, 2022
@filiphr
Copy link
Member

filiphr commented Nov 3, 2022

Thanks @chenzijia12300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjaakd sjaakd sjaakd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot use only BeanMapping#mappingControl

3 participants

@chenzijia12300 @filiphr @sjaakd