#3037 Make @ValueMapping and @ValueMappings support combinations #3043
Conversation
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
Thanks @chenzijia12300. The implementation looks good. However, I think that we need to change the location of the test a bit.
We should not touch the CompositionTest. Instead I would suggest creating a new ValueCompositionTest in a new package org.mapstruct.ap.test.value.composition and also put the CustomValueAnnotation and ValueMappingCompositionMapper in that package.
...ssor/src/test/java/org/mapstruct/ap/test/mappingcomposition/value/CustomValueAnnotation.java
Outdated
Show resolved
Hide resolved
|
@filiphr Thank you for pointing it out, I have made the changes ;D |
|
Everything looks good @chenzijia12300, I was about to merge this. However, I remembered that perhaps it will be good to add an example to the documentation as well. Can you please add a new section to the Mapping Values chapter? |
|
@filiphr No problem, I'll try to add an example to the documentation |
|
Thanks @chenzijia12300 |
3 participants
Fixes #3037