Typo in java-docs #2989
Closed
Typo in java-docs #2989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiphr
reviewed
Aug 26, 2022
Member
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
All changes look good @prasanth08. I have only one small comment about the link
...r/src/main/java/org/mapstruct/ap/internal/conversion/AbstractJavaTimeToStringConversion.java
Outdated
Show resolved
Hide resolved
Member
|
Thanks for your changes @prasanth08. Not sure if you saw, but it seems like your last change broke the javadoc generation. |
Contributor
Author
|
@filiphr It was an issue of the self closing tag . Fixed it 😀 |
Member
|
Thanks @prasanth08. I manually merged this in 68571de |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.