#2925 Fix IllegalArgumentException when resolving generic parameters #2977
Conversation
…rameters When resolving the parameter for a method like: <T> Optional<T> from(T value) There was an exception in javac because getting a DeclaredType from an Optional with a primitive type argument throws an exception. Therefore, when assigning the type arguments we get the boxed equivalent. This problem does not happen in the Eclipse compiler
|
@sjaakd it would be good if you can have a look at this. This is in the area you worked on for the generics matching 😄 |
sjaakd
left a comment
sjaakd
left a comment
There was a problem hiding this comment.
LGTM. However javadoc could be improved
| return null; | ||
| } | ||
| typeArgs[i] = matchingType.getTypeMirror(); | ||
| typeArgs[i] = matchingType.getBoxedEquivalent().getTypeMirror(); |
There was a problem hiding this comment.
I guess this works because if this is not a boxed type it will return type. Perhaps add a comment here. And the javadoc on getBoxedEquivalent should be adapted 😄
There was a problem hiding this comment.
Perhaps there are more occasions this situation arises. I believe that I somehow covered the scenario where the target is a generic parameter itself in the testcases. Lets just wait and see if more pop up.
There was a problem hiding this comment.
The Javadoc says:
Gets the boxed equivalent type if the type is primitive, int will return Integer
What more do you think I should add?
I'll add a comment on the line
2 participants
When resolving the parameter for a method like:
There was an exception in javac because getting a DeclaredType from an Optional
with a primitive type argument throws an exception.
Therefore, when assigning the type arguments we get the boxed equivalent.
This problem does not happen in the Eclipse compiler
Fixes #2925