#2945 Stabilise top level imports #2973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that GeneratedType always gets the imported types from a Type before adding them
sjaakd
approved these changes
Aug 23, 2022
| } | ||
|
|
||
| if ( needsImportDeclaration( typeToAdd ) ) { | ||
| collection.add( typeToAdd ); |
Contributor
There was a problem hiding this comment.
ok.. how could this work in the first place? Now we don't add typeToAdd itself, but the required imported types..
Member
Author
There was a problem hiding this comment.
Have a look at the Type implementation. We are a bit smart there when we need to do an import and only use the TopLevel.Nested for nested. There is a complex logic for computing whether we need to import a type or not.
When I did the initial work for this I changed a lot of places where we were adding types to actually return Type#getImportedTypes, but apparently this is not everywhere (considering the bug reports we've been receiving)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that GeneratedType always gets the imported types
from a Type before adding them
Fixes #2945
Fixes #2907