Skip to content

Add support for Jakarta CDI #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
filiphr merged 2 commits into from
Aug 24, 2022
Merged

Add support for Jakarta CDI #2970

filiphr merged 2 commits into from
Aug 24, 2022

Conversation

@filiphr
Copy link
Member

@filiphr filiphr commented Aug 21, 2022 •
edited
Loading

Fixes #2950

sjaakd
sjaakd approved these changes Aug 23, 2022
View reviewed changes
processor/src/main/java/org/mapstruct/ap/internal/processor/CdiComponentProcessor.java
return true;
}

private Type getType(String simpleName) {
Copy link
Contributor

@sjaakd sjaakd Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getCDIType

Copy link
Member Author

@filiphr filiphr Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to complicate things. This also fetches the @Inject from the inject package as well

@filiphr filiphr merged commit 874bf1f into mapstruct:main Aug 24, 2022
@filiphr filiphr deleted the 2950-jakarta-cdi branch August 24, 2022 16:38
@Felk
Copy link

Felk commented Feb 13, 2023

Hello, I am curious if this is landing in a release any time soon? I am playing around with Quarkus 3.0.0 Alpha4, which includes the transition from the javax to jakarta namespace. Being able to just switch the component model from CDI to JAKARTA_CDI would mean mapstruct is well-prepared with a clear migration path once Quarkus 3.0 hits stable 😁

@edeandrea
Copy link

edeandrea commented Feb 23, 2023

I too am looking for this feature because of Quarkus 3 & the move to the jakarta namespace. RIght now I really have no workaround as @Singleton does not work (because I mock/spy using Mockito) and you can't mock/spy on @Singleton beans. It needs to be @ApplicationScoped.

@edeandrea
Copy link

edeandrea commented Feb 23, 2023

@filiphr / @sjaakd Please see previous comments.

@edeandrea edeandrea mentioned this pull request Feb 23, 2023
Closed
@filiphr
Copy link
Member Author

filiphr commented Apr 15, 2023

This has now been backported to 1.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjaakd sjaakd sjaakd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for Jakarta @ApplicationScoped is missing

4 participants

@filiphr @Felk @edeandrea @sjaakd