#2839 keep thrown types when creating a new ForgedMethod with the same arguments #2844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaakd
requested changes
May 29, 2022
processor/src/test/java/org/mapstruct/ap/test/bugs/_2839/CarMapper.java
Outdated
Show resolved
Hide resolved
processor/src/test/java/org/mapstruct/ap/test/bugs/_2839/CarMapper.java
Outdated
Show resolved
Hide resolved
hakan0xFF
force-pushed
the
keep-thrown-types
branch
from
8557f53 to
5ab0baf
Compare
…h the same arguments
hakan0xFF
force-pushed
the
keep-thrown-types
branch
from
5ab0baf to
3946e29
Compare
Member
|
@hakan0xFF I've applied the requested changes by @sjaakd to your branch and pushed it. Once the tests are green I am going to merge this PR. Thanks for your work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2839