Skip to content

Replace semantic_similarity_* slots by similarity_* slots#386

Merged
matentzn merged 5 commits intomasterfrom
similarity-score
Aug 6, 2024
Merged

Replace semantic_similarity_* slots by similarity_* slots#386
matentzn merged 5 commits intomasterfrom
similarity-score

Conversation

@matentzn
Copy link
Copy Markdown
Collaborator

@matentzn matentzn commented Aug 4, 2024 •
edited
Loading

Fixes #385

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

If you are proposing a change to the SSSOM metadata model, you must

  • provide a full, working and valid example in examples/
  • provide a link to the related GitHub issue in the see_also field of the linkml model
  • provide a link to a valid example in the see_also field of the linkml model
  • run SSSOM-Py test suite against the updated model

@matentzn matentzn changed the title Similarity score Replace semantic_similarity_* slots by similarity_* slots Aug 4, 2024
@matentzn matentzn marked this pull request as ready for review August 4, 2024 16:29
@matentzn matentzn requested a review from gouttegd August 4, 2024 16:29
gouttegd
gouttegd previously approved these changes Aug 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

@matentzn matentzn added the schema label Aug 4, 2024
@matentzn matentzn self-assigned this Aug 4, 2024
@matentzn matentzn requested review from ehartley and hrshdhgd August 4, 2024 16:46
hrshdhgd
hrshdhgd requested changes Aug 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@hrshdhgd hrshdhgd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to update files that are dependent on this YAML change. For example sssom_schema.py and others (if any). Run make all I think?

sssom/Makefile

Lines 44 to 53 in d2b9d7e

all: gen-project gendoc gen-excel get-context
%.yaml: gen-project
deploy: all mkd-gh-deploy
# generates all project files
gen-project: $(PYMODEL)
$(RUN) gen-project \
--exclude owl \
-d $(DEST) $(SOURCE_SCHEMA_PATH) && mv $(DEST)/*.py $(PYMODEL)

This was referenced Aug 5, 2024
Merged
Merged
Merged
Merged
@hrshdhgd hrshdhgd self-requested a review August 5, 2024 14:09
hrshdhgd
hrshdhgd previously approved these changes Aug 5, 2024
View reviewed changes
ehartley
ehartley reviewed Aug 6, 2024
View reviewed changes
ehartley
ehartley reviewed Aug 6, 2024
View reviewed changes
@matentzn @ehartley
Fix two typos in docs
a223b24 
thank you @ehartely

Co-authored-by: Emily Hartley <[email protected]>
@matentzn matentzn dismissed stale reviews from hrshdhgd and gouttegd via a223b24 August 6, 2024 07:10
@matentzn matentzn requested review from ehartley and hrshdhgd August 6, 2024 07:10
@matentzn matentzn merged commit 717afcb into master Aug 6, 2024
@matentzn matentzn deleted the similarity-score branch August 6, 2024 07:12
@matentzn
Copy link
Copy Markdown
Collaborator Author

matentzn commented Aug 6, 2024

Thank you @ehartley @hrshdhgd @gouttegd for your reviews! I merged this, because @hrshdhgd and @gouttegd have approved, and @ehartley fixed two typos - no need for re-review for these (judgement call - let me know if we should not do that for procedural reasons).

@gouttegd gouttegd mentioned this pull request Aug 7, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gouttegd gouttegd gouttegd left review comments

@ehartley ehartley Awaiting requested review from ehartley

@hrshdhgd hrshdhgd Awaiting requested review from hrshdhgd

Assignees

@matentzn matentzn

Labels

schema

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate semantic_similarity_* slots in favour of the more generic similarity_* slots

4 participants

@matentzn @hrshdhgd @ehartley @gouttegd