Skip to content

Change subject and object source references to be CURIEs in table format#177

Merged
matentzn merged 2 commits intomasterfrom
issue126-sourcecurie
Jun 3, 2022
Merged

Change subject and object source references to be CURIEs in table format#177
matentzn merged 2 commits intomasterfrom
issue126-sourcecurie

Conversation

@matentzn
Copy link
Copy Markdown
Collaborator

Fixes #126

This PR changes the datatype of the subject_source an object_source from uri (which includes arbitrary URLs) to entity reference, including some examples.

examples:
- value: http://purl.obolibrary.org/obo/mondo.owl
description: (A persistent IRI pointing to the latest version of the Mondo ontology.)
- value: obo:mondo.owl
Copy link
Copy Markdown
Contributor

@cmungall cmungall Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's slightly unsatisfying we don't have a way to specify the logical resource independent of serialization format. See OBOFoundry/purl.obolibrary.org#852

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I 100% agree. obo:mondo would be better here as the canonical way to refer to OBO ontologies.

@matentzn matentzn merged commit aab0139 into master Jun 3, 2022
@matentzn matentzn deleted the issue126-sourcecurie branch June 3, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the subject/object source type to something like prefix

3 participants