Repository navigation
Demote the Azure apt mirror on Blacksmith runners too - #935
Merged
Merged
Conversation
Blacksmith x64 runners read /etc/apt/blacksmith-ubuntu-mirrors.txt rather than GitHub's /etc/apt/apt-mirrors.txt, so the existing demotion never reached them, and a crawling Azure mirror spent 21 minutes of the hygiene job on one apt-get install. Demote Azure in either list, add archive.ubuntu.com when it is the only mirror, and print both lists.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hygiene job on #932 timed out because
jdx/mise-actionspent 21 of its 30 minutes in oneapt-get install. Every package came fromazure.archive.ubuntu.comat tens of kB/s, andlibclang-18-dev(28.8 MB) took 9 minutes before apt gave up and fetched it again (log).bound-apt.shalready exists to avoid that mirror, but it only demotes Azure in GitHub's/etc/apt/apt-mirrors.txt. Blacksmith x64 runners read/etc/apt/blacksmith-ubuntu-mirrors.txtinstead: apt's first fetch in that job wasGet:1 file:/etc/apt/blacksmith-ubuntu-mirrors.txt Mirrorlist. The edit landed in a file that apt never read.The script now demotes Azure in either list, using the same
mirror+fileformat (a URL, then tab-separatedpriority:N, lower first):priority:9. One without a priority getspriority:9appended.archive.ubuntu.comgetshttps://archive.ubuntu.com/ubuntu/ priority:2, so apt has a mirror to fail over to.The edit also stopped using
sed 's/priority:1/priority:9/', which rewrote everypriority:1in the file, includingpriority:10, not just Azure's line.Validation outside CI: I ran the loop against four sample lists with macOS awk: GitHub's current list, an Azure-only list without a priority, Azure beside another mirror, and a list without Azure. Each came out as described above. I haven't seen the contents of Blacksmith's list, because the old script never printed it; this PR's CI log will show it.
AI-assisted — Tool: Claude Code; model: Anthropic/claude-opus-5-5