Add CONTEXT_PATH support for sub-path deployments#3944
Conversation
Implements issue mapfish#3728: allow running behind a reverse proxy under a sub path by configuring servlet mappings and UI base href via CONTEXT_PATH.
|
@spike83 I have assign to review your PR. But it is not successfully building. Could you please fix you PR, then I will review it. |
|
@sbrunner Could we do sthg about Pull request links that never stops running ? |
spike83
force-pushed
the
issue-3728-context-path
branch
from
eabe877 to
901814b
Compare
|
@sebr72 I just blacklist 'issue' to be a Jira project. |
|
I just closed and reopened it to be sure that the integration tests are passing. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Prefix the servlet mappings (for example <code>/metrics</code> becomes <code>/print/metrics</code>). | ||
| </li> |
There was a problem hiding this comment.
The documentation example is slightly misleading. It states that /metrics becomes /print/metrics, which is correct. However, it doesn't clarify what happens to the existing /print/* servlet mapping. With CONTEXT_PATH=/print, the servlet mapping /print/* would become /print/print/*, meaning the print API would be accessible at /print/print/... rather than just /print/.... This could confuse users.
Consider adding a note that the CONTEXT_PATH should not conflict with existing servlet paths (/print or /sec/print), or document the resulting double-path behavior explicitly.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Pull request was closed
Implements issue #3728: allow running behind a reverse proxy under a sub path by configuring servlet mappings and UI base href via CONTEXT_PATH.