Remove 'martinbeentjes/npm-get-version-action' from release workflow#887
Merged
benmccann merged 1 commit intomapbox:masterfrom Dec 7, 2024
Merged
Conversation
Merged
benmccann
approved these changes
Dec 7, 2024
Contributor
Author
|
Nice, at least the workflow ran this time. It saw that 1.0.11 was already published, so it didn't actually publish anything yet....but at least it ran.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the 'martinbeentjes/npm-get-version-action' from the release workflow.
I am already getting this value in the first job, so I just added that to the outputs and used that variable where 'steps.package-version.outputs.current-version' was used before.
I tested this in my fork and it looks like it pulls the version as expected
https://github.com/WifiDB/node-pre-gyp/actions/runs/12215279116
https://github.com/WifiDB/node-pre-gyp/releases/tag/v2.0.0-rc.3
https://www.npmjs.com/package/@acalcutt/node-pre-gyp-test/v/2.0.0-rc.3