Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Split up buffers#2103

Merged
kkaefer merged 1 commit intomasterfrom
2103-split-up-buffers
Oct 2, 2015
Merged

Split up buffers#2103
kkaefer merged 1 commit intomasterfrom
2103-split-up-buffers

Conversation

@kkaefer
Copy link
Member

@kkaefer kkaefer commented Oct 1, 2015

We're currently reusing buffers until they fill up to 65535 vertices. Instead, every logical buffer should have its own buffer rather than sharing them.

@kkaefer kkaefer self-assigned this Oct 1, 2015
@kkaefer
Copy link
Member Author

kkaefer commented Oct 1, 2015

  • Benchmark

@kkaefer kkaefer force-pushed the 2103-split-up-buffers branch 2 times, most recently from b0a63d2 to 47d3def Compare October 2, 2015 12:28
@kkaefer
Copy link
Member Author

kkaefer commented Oct 2, 2015

This looks good performance wise; couldn't measure any difference on iPad.

@kkaefer kkaefer force-pushed the 2103-split-up-buffers branch from 47d3def to a080f10 Compare October 2, 2015 12:58
This allows changing individual buckets without having leftover data
@kkaefer kkaefer force-pushed the 2103-split-up-buffers branch from a080f10 to 3d834b5 Compare October 2, 2015 13:05
@kkaefer kkaefer merged commit 3d834b5 into master Oct 2, 2015
@kkaefer kkaefer deleted the 2103-split-up-buffers branch October 2, 2015 13:06
@jfirebaugh
Copy link
Contributor

Great, much simpler.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants