Merged
Conversation
mollymerp
requested review from
ChrisLoer,
ajashton,
anandthakker,
asheemmamoowala and
jfirebaugh
and removed request for
ajashton
mollymerp
force-pushed
the
v0.45.0-beta.1
branch
from
8c6781f to
29b0c56
Compare
ChrisLoer
approved these changes
Apr 20, 2018
Contributor
ChrisLoer
left a comment
ChrisLoer
left a comment
There was a problem hiding this comment.
Changelog looks good to me!
I don't know the context for the evented/mapbox-gl-draw change...
mollymerp
force-pushed
the
v0.45.0-beta.1
branch
from
29b0c56 to
1b6c61e
Compare
jfirebaugh
approved these changes
Apr 21, 2018
CHANGELOG.md
Outdated
| * Fix bug in cross-fading for `*-pattern` properties with non-integer zoom stops [#6430](https://github.com/mapbox/mapbox-gl-js/pull/6430) | ||
| * Fix bug where calling `Map#remove` on a map with constructor option `hash: true` throws an error (h/t @allthesignals) [#6490](https://github.com/mapbox/mapbox-gl-js/pull/6497) | ||
| * Fix bug causing flickering when panning across the anti-meridian [#6438](https://github.com/mapbox/mapbox-gl-js/pull/6438) | ||
| * Return an empty string instead of `"null"` from the expression `["to-string", null]` [#6534](https://github.com/mapbox/mapbox-gl-js/pull/6534) |
Contributor
There was a problem hiding this comment.
This one is called out in the "breaking changes" section already.
CHANGELOG.md
Outdated
| * Add `anchor` option to `Marker` [#6350](https://github.com/mapbox/mapbox-gl-js/pull/6350) | ||
| * `HTMLElement` is now passed to `Marker` as part of the `options` object, but the old function signature is still supported for backwards compatibility [#6356](https://github.com/mapbox/mapbox-gl-js/pull/6356) | ||
| * Add support for custom colors when using the default `Marker` SVG element (h/t @andrewharvey) [#6416](https://github.com/mapbox/mapbox-gl-js/pull/6416) | ||
| * Allow `CanvasSource` initialization from`HTMLElement` [#6424](https://github.com/mapbox/mapbox-gl-js/pull/6424) |
CHANGELOG.md
Outdated
| * Fix label collision circle debug drawing on overzoomed tiles [#6073](https://github.com/mapbox/mapbox-gl-js/pull/6073) | ||
| * Improve error reporting for some failed requests [#6126](https://github.com/mapbox/mapbox-gl-js/pull/6126), [#6032](https://github.com/mapbox/mapbox-gl-js/pull/6032) | ||
| * Fix several `Map#queryRenderedFeatures` bugs: | ||
| - account for `{text, icon}-offset` or `{text, icon}-rotate` when querying[#6135](https://github.com/mapbox/mapbox-gl-js/pull/6135) |
Contributor
There was a problem hiding this comment.
I think only *-offset actually got fixed.
CHANGELOG.md
Outdated
| * Fix bug causing an off-by-one error in `array` expression error messages (h/t @drewbo) [#6269](https://github.com/mapbox/mapbox-gl-js/pull/6269) | ||
| * Improve error message when an invalid access token triggers a 401 error [#6283](https://github.com/mapbox/mapbox-gl-js/pull/6283) | ||
| * Fix bug where lines with `line-width` larger than the sprite height of the `line-pattern` property would render other sprite images [#6246](https://github.com/mapbox/mapbox-gl-js/pull/6246) | ||
| * Fix bug where touch events do not work on mobile using Edge [#6325](https://github.com/mapbox/mapbox-gl-js/pull/6325) |
Contributor
There was a problem hiding this comment.
Note that the fix here is limited to panning -- zoom/rotate/pitch via touch is still broken on Edge. (#1928)
mollymerp
force-pushed
the
v0.45.0-beta.1
branch
from
1b6c61e to
8fd77ce
Compare
mollymerp
force-pushed
the
v0.45.0-beta.1
branch
from
8fd77ce to
a56e6c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.