Closed
Conversation
Contributor
|
This has a potential performance impact, right? It's now calling We could make |
Contributor
Author
|
Yeah, it's making LineBucket around 25% slow. Waiting until the function par is implemented sounds good. |
Instead of having one layout property value for an entire layer, calculate values separately for each feature. This will eventually enable things like multiple different fonts within a single layer. Since the style functions don't support data driven styles yet, there is no way for functions to return different results per-feature.
constant values for these features can be added to and read from the buffers: line-color line-width line-blur line-gap-width line-opacity text-color icon-color text-halo-color icon-halo-color icon-opacity
ansis
force-pushed
the
per-feature-layout-props
branch
from
8da9867 to
0fb7bff
Compare
ansis
force-pushed
the
per-feature-layout-props
branch
from
83ca3f1 to
b0dfc7b
Compare
Contributor
|
Rolled into #1300. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having one layout property value for an entire layer, calculate values separately for each feature. This will eventually enable things like multiple fonts within a single layer.
Since the style functions don't make use of the feature properties yet all properties within a layer still have identical values.
This should not have any impact rendering.
@jfirebaugh want to review?