Conversation
mourner
approved these changes
Dec 23, 2019
Member
mourner
left a comment
mourner
left a comment
There was a problem hiding this comment.
Looks good to me at a quick skim. There seem to be a ton of export default { ... a singleton with a bunch of properties ... } which could possibly be refactored so that each of the properties is a named export (where possible), but this could be left for a later PR.
Member
Author
Yeah, I'm aware of that; it's a result of my semi-automated conversion. My plan was to leave this for a follow-up PR in the interest of making this PR easier to review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also made benchmarks functional again; some are still a bit buggy though.