Trash correct vertices by changing sort to be numeric-aware#943
Merged
Trash correct vertices by changing sort to be numeric-aware#943
Conversation
mourner
approved these changes
Dec 18, 2019
Member
mourner
left a comment
mourner
left a comment
There was a problem hiding this comment.
👍 I wasn't aware of this usage of localeCompare — perhaps it would be simpler to coerce to numbers for sorting, but leaving up to you whether to accept the suggestion.
| // Uses number-aware sorting to make sure '9' < '10'. Comparison is reversed because we want them | ||
| // in reverse order so that we can remove by index safely. | ||
| state.selectedCoordPaths | ||
| .sort((a, b) => b.localeCompare(a, 'en', { numeric: true })) |
Member
There was a problem hiding this comment.
Suggested change
| .sort((a, b) => b.localeCompare(a, 'en', { numeric: true })) | |
| .sort((a, b) => +b - a) |
Member
Author
There was a problem hiding this comment.
This doesn't work for sort keys that are deeply nested, e.g. 0.8.9 should be sorted before 0.8.10
Member
Author
There was a problem hiding this comment.
I tested that this works with localeCompare's numeric sort:
console.warn(['11', '10', '9', '33', '8', '30', '3'].sort((a, b) => b.localeCompare(a, 'en', { numeric: true })));
console.warn(['4.11', '4.10', '40.8', '4.9', '4.33',].sort((a, b) => b.localeCompare(a, 'en', { numeric: true })));
console.warn(['4.10.34', '4.10.3', '4.10.29'].sort((a, b) => b.localeCompare(a, 'en', { numeric: true })));
Member
There was a problem hiding this comment.
Oh, I didn't realize those weren't just numbers, which wasn't clear from the comment. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #897 by correctly sorting coordinate paths prior to deletion.
We're using "coordinate paths" to store which vertices are selected. These paths are stringified indices into the coordinates array, and can be multiple levels deep separated by
.. When deleting vertices, we sort them in reverse order to make sure that we invalidate the indices by deleting vertices that come before another vertices scheduled for deletion. This works if we have fewer than 10 vertices. However, the alphabetical sort means that we'd delete note10before node9. This PR fixes this by using a numeric sort.