Conversation
|
@drewbo thanks for this. I know turning of interactivity is something a bunch of people are interested in so its good to see movement here. Here are the things I think are left to do.
|
src/modes/static.js
Outdated
| module.exports = function(ctx) { | ||
| return { | ||
| stop: function() { | ||
| ctx.map.doubleClickZoom.enable(); |
There was a problem hiding this comment.
This can use the doubleClickZoom lib function: https://github.com/mapbox/mapbox-gl-draw/blob/master/src/lib/double_click_zoom.js
There was a problem hiding this comment.
Actually, though, I'm confused as to why this needs to enable the zoom. Don't the other modes that disable zoom clean themselves up?
There was a problem hiding this comment.
Yup, I think this is mostly me being sloppy when I was first adding it for myself. I'll remove.
|
@mcwhittemore made the changes above with two remaining items to hit that I could use some assistance on:
|
Oh man. Not sure. Maybe you can console log it out.
Yea, that sounds good to me. |
|
@mcwhittemore updated the fixture. I left the other issue as is because I couldn't reliably |
|
@drewbo this is looking good. The only problem I see is that the cursor still changes to 👆 hand when I hover over the feature in static mode. Lets fix this up (add mode classes to the cursors css) and then rebase and we should be good. Thanks! |
|
@mcwhittemore will do. Do we still need to rebase if we can squash the commits with GH? |
|
@drewbo um, as long as the |
|
Not positive what the |
|
@drewbo I'm talking about the warning git hub is displaying above the comment box. |
|
Ah, got it. I don't see those but I merged master on. |
|
@drewbo merged and published (0.11.2). We're keeping the 0.10.x line as the main line in npm now so make sure you install 0.11.2 specifically. |

Ref #109 cc: @mcwhittemore
Happy to make any adjustments to make this more resilient, can add a few tests too