refactor: use key with fallback to keyCode for compatibility#1394
Merged
underoot merged 3 commits intomapbox:mainfrom May 5, 2025
Merged
refactor: use key with fallback to keyCode for compatibility#1394underoot merged 3 commits intomapbox:mainfrom
key with fallback to keyCode for compatibility#1394underoot merged 3 commits intomapbox:mainfrom
Conversation
underoot
reviewed
May 2, 2025
Member
underoot
left a comment
underoot
left a comment
There was a problem hiding this comment.
Thank you for your contribution! Left some comments, overall looks good!
erotourtes
commented
May 2, 2025
Contributor
Author
erotourtes
left a comment
erotourtes
left a comment
There was a problem hiding this comment.
Thank you for taking the time to review this!
underoot
approved these changes
May 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
keyCodeproperty is deprecated and may, or may not be supported in modern browsersThis PR updates functions to check for
keyproperty and fallback tokeyCodefor compatibility with older browsers that don't support the key property.