Use native crypto.randomUUID() instead of hat module#1274
Closed
varna wants to merge 1 commit intomapbox:mainfrom
Closed
Use native crypto.randomUUID() instead of hat module#1274varna wants to merge 1 commit intomapbox:mainfrom
crypto.randomUUID() instead of hat module#1274varna wants to merge 1 commit intomapbox:mainfrom
Conversation
Member
|
Hello, @varna! Thank you for your contribution! To me, it seems that replacing of hat with crypto.randomUUID() will cause inability to use maps on site without HTTPS. I agree that |
Member
|
Thank you for contribution! We decided to go with nanoid because of non-secure contexts #1318 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reducing number of dependencies by replacing
hatmodule with nativecrypto.randomUUID()which is well supported:https://developer.mozilla.org/en-US/docs/Web/API/Crypto/randomUUID#browser_compatibility
https://caniuse.com/mdn-api_crypto_randomuuid
This would push
mapbox-gl-drawdev env to node 20 (or deno/bun). Node 18 is reaching end of maintenance next year, so idk if that's an issue for you.