Merged
Conversation
mourner
reviewed
Jun 27, 2024
Member
mourner
left a comment
There was a problem hiding this comment.
Nice! Why do we need ESBuild though if we still use Rollup?
Contributor
Author
|
You are right, we don't need to transpile with esbuild for older browsers anymore 👍 |
mourner
reviewed
Jun 27, 2024
d191167 to
9da02f4
Compare
9da02f4 to
0a1e9f5
Compare
mourner
approved these changes
Jun 27, 2024
Member
mourner
left a comment
There was a problem hiding this comment.
Nice! Something I've been doing recently is also removing tape and nyc in favor of native Node test runner and coverage — see if it makes sense to do so here, but not too important.
underoot
approved these changes
Jun 28, 2024
This was referenced Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bublecompilerand switch to theesbuildxtend, useObject.assigninsteadlodash.isequal, usefast-deep-equalinsteadvitefor the local developmentThe minified bundle size dropped from 80K to 68K.
The benchmarks primarily use the previous setup.