Draw should not interfere with dragPan.disable() #1216
Merged
stepankuzmin merged 6 commits intomapbox:mainfrom Jul 1, 2024
Merged
Draw should not interfere with dragPan.disable() #1216stepankuzmin merged 6 commits intomapbox:mainfrom
stepankuzmin merged 6 commits intomapbox:mainfrom
Conversation
…hen direct_select has disabled it
…hen direct_select has disabled it
Contributor
Author
|
@stepankuzmin PTAL :D |
axekan
added a commit
to axekan/mapbox-gl-draw
that referenced
this pull request
Jun 24, 2024
stepankuzmin
approved these changes
Jul 1, 2024
Contributor
stepankuzmin
left a comment
stepankuzmin
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the contribution @itoxiq 👍
This was referenced Jul 1, 2024
|
@itoxiq @stepankuzmin hey guys, after clicking the same feature multiple times without moving the mouse, doesn't it happen to you that dragPan remains disabled, regardless of whether it was initially enabled? I just updated to version 1.5.0, and this issue started happening. E.g.: If you manage to fire 2 consecutive startDragging, any stopDragging after that won't turn on the dragPan again EDIT: Created this issue: #1328 |
Member
|
@fede-qubika The issue was addressed. Thank you for the report! Release with the fix will be done later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #1191
The issue is that Draw assumes that dragPan is enabled and simply enables it without question after certain operations (when dragpan is temporarily disabled). This change would set a variable called initialDragPanState and only re-enables when it was originally enabled.