Updated controls ordering and UI tooltips to be consistent with keybindings#1209
Closed
georgemoon wants to merge 0 commit intomapbox:mainfrom
georgemoon:main
Closed
Updated controls ordering and UI tooltips to be consistent with keybindings#1209georgemoon wants to merge 0 commit intomapbox:mainfrom georgemoon:main
georgemoon wants to merge 0 commit intomapbox:mainfrom
georgemoon:main
Conversation
stepankuzmin
approved these changes
Feb 20, 2024
Contributor
stepankuzmin
left a comment
stepankuzmin
left a comment
There was a problem hiding this comment.
Good catch! Thanks @georgemoon 👍
Author
|
Hey @underoot @stepankuzmin, I think this change is still relevant but doesn't appear to have been included in the latest refactor. Could you maybe take another look? It's a relatively simple fix! Thanks |
Member
|
Hey, @georgemoon! You are right, by mistake your changes haven't been included into v1.5.0. I've refreshed PR branch and changes for some reasons weren't reflected in GitHub and I thought that changes already propogated to |
Author
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point the Mapbox Draw keybindings were changed, and are now:
(1) Point
(2) Line
(3) Polygon
whereas the tooltips still have the letters l/p/m.
This pull request changes the tooltips, and also the ordering of the controls to be consistent with the numbering used.
Addresses #1103