fix: trigger featureChanged on feature props change#1201
Merged
stepankuzmin merged 1 commit intomapbox:mainfrom Dec 11, 2023
Merged
fix: trigger featureChanged on feature props change#1201stepankuzmin merged 1 commit intomapbox:mainfrom
stepankuzmin merged 1 commit intomapbox:mainfrom
Conversation
mapbox#1196 intended to add a call to `featureChanged` any time a feature was `add()`ed with modified properties, however it has a bug in that the check came after assignment. A simpler fix would be to move the assignment inside the `if()` body, but that could break other code that depended on referential equality after calling `add()`.
|
This is an issue I have run into as well, and I believe this PR would fix it. Any chance this PR could get reviewed and merged? |
|
Hey, we are also having trouble with features not rerendering on property changes, is there plans to get this PR merged? |
Contributor
Author
|
I'd also like to see this reviewed and merged, but I think we're waiting on a project maintainer for the next step. Happy to do whatever is needed on my side |
stepankuzmin
approved these changes
Dec 11, 2023
Contributor
stepankuzmin
left a comment
stepankuzmin
left a comment
There was a problem hiding this comment.
Good catch, @petermoz. Thanks for the contribution! This looks good to me 👍
danielsippel
added a commit
to danielsippel/mapbox-gl-draw
that referenced
this pull request
Apr 17, 2024
)" This reverts commit e3cb6bc.
danielsippel
added a commit
to danielsippel/mapbox-gl-draw
that referenced
this pull request
Apr 18, 2024
…apbox#1201)"" This reverts commit 28a4922.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1196 intended to add a call to
featureChangedany time a feature wasadd()ed with modified properties, however it has a bug in that the check came after assignment.An alternative to this fix would be to move the assignment inside the
if()body, but that could break other code that depended on referential equality after callingadd().I verified the fix by hacking the demo to include a button which modified a property on a feature, and also hacked the stylesheet to render that property as a label. Code here: petermoz@132d2d2
I had a look at adding tests but couldn't figure out how to best get access to
store.getChangedIdsfrom the the API test. Happy to add tests if you have a suggestion about accessing the store.