In key event handler, check for map canvas using classList.contains()#1165
Merged
stepankuzmin merged 1 commit intomapbox:mainfrom Mar 6, 2023
Merged
In key event handler, check for map canvas using classList.contains()#1165stepankuzmin merged 1 commit intomapbox:mainfrom
stepankuzmin merged 1 commit intomapbox:mainfrom
Conversation
stepankuzmin
approved these changes
Mar 6, 2023
Contributor
stepankuzmin
left a comment
stepankuzmin
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @neodescis 👍
gynekolog
pushed a commit
to gynekolog/mapbox-gl-draw
that referenced
this pull request
Jun 5, 2023
…eodescis) Co-authored-by: Nick Steinbaugh <[email protected]>
gynekolog
pushed a commit
to gynekolog/mapbox-gl-draw
that referenced
this pull request
Jun 5, 2023
…eodescis) Co-authored-by: Nick Steinbaugh <[email protected]>
danielsippel
added a commit
to danielsippel/mapbox-gl-draw
that referenced
this pull request
Apr 17, 2024
… (h/t @neodescis)" This reverts commit acd3500.
danielsippel
added a commit
to danielsippel/mapbox-gl-draw
that referenced
this pull request
Apr 18, 2024
…ox#1165) (h/t @neodescis)"" This reverts commit 441a0e1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1135
Had to update test events to include a contains() function.