Revert "Use passive event listeners instead of preventDefault"#1158
Merged
stepankuzmin merged 1 commit intomainfrom Feb 14, 2023
Merged
Revert "Use passive event listeners instead of preventDefault"#1158stepankuzmin merged 1 commit intomainfrom
preventDefault"#1158stepankuzmin merged 1 commit intomainfrom
Conversation
… (h/t @danielsippel)" This reverts commit 84e35b7.
This was referenced Feb 14, 2023
Merged
danielsippel
added a commit
to danielsippel/mapbox-gl-draw
that referenced
this pull request
Apr 17, 2024
…t` (mapbox#1146) (h/t @danielsippel)" (mapbox#1158)" This reverts commit 5a90472.
danielsippel
added a commit
to danielsippel/mapbox-gl-draw
that referenced
this pull request
Apr 18, 2024
…ntDefault` (mapbox#1146) (h/t @danielsippel)" (mapbox#1158)"" This reverts commit 773abe7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @danielsippel,
I'm going to revert the #1146 since it currently breaks the touch events as reported in #1154. I missed it during the manual testing, and we'd need to look for a different way to do it. Sorry for the inconvenience.