Conversation
ansis
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes and cleans up development dependencies in the project to get rid of all security alerts and make it more maintainable. There's a lot of changes, but all commits here are self-contained so you can review one by one.
browserify— it basically stopped being used after first step of ES6 conversion + browserify -> rollup #945 but wasn't removed.mapbox-gldepedency — it was used only for theEventedclass used for benchmarks, but I wrote a minimal standaloneEventedinstead to avoid the dependency, and used CDN links for the debug/bench pages instead of serving fromnode_modules.@mapbox/flow-remove-typesbecause it's no longer needed after eliminatingmapbox-gldependency.mapbox-gl-js-mockdependency — it's been unmaintained for 5 years and it was originally written formapbox-gl-drawtests anyway, so I wrote a new mock implementation vendored in this repo.expressand the customserver.jsbecause after the Rollup change, we can serve everything statically.rollup-plugin-node-builtinsbecause it became unnecessary after Remove GeoJSON validation #1052 — we no longer use any Node built-ins in the bundle.