Remove geojson-flatten dependency#1066
Merged
stepankuzmin merged 3 commits intomapbox:mainfrom Jun 28, 2024
Merged
Conversation
stepankuzmin
approved these changes
Jun 28, 2024
Contributor
stepankuzmin
left a comment
stepankuzmin
left a comment
There was a problem hiding this comment.
Hey @stevage,
Thanks for the contribution, and sorry for the delayed response. This change also saves 8K in the resulting bundle 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This dependency on geojson-flatten (which itself has several more) is easily replaced.
It also turns out many of the tests to
constrainFeatureMovement()were supplying faulty Polygon coordinates.(Motivation: this was causing me some kind of spurious packaging errors when making other changes, the classic Webpack issue with
require()and.defaultetc etc)