Optimize size of mapbox-gl-draw.css from 33 KB to 5 KB#1038
Merged
asheemmamoowala merged 4 commits intomapbox:mainfrom Apr 9, 2021
Merged
Optimize size of mapbox-gl-draw.css from 33 KB to 5 KB#1038asheemmamoowala merged 4 commits intomapbox:mainfrom
asheemmamoowala merged 4 commits intomapbox:mainfrom
Conversation
• Remove geometry outside the viewbox • Remove unused and unnecessary complex geometry and definitions inside the viewbox • Optimize geometry representation to compound paths • Optimizing number of decimals from six to one through ImageOptim (lossy, yes, but not noticeable) • Represent svgs as svgs in css, not Base64 encoded svgs (Base64 encoding of well written svgs is meaningless – it just increases the file size).
|
This causes measurable improvements in load times - could this patch get some attention? |
asheemmamoowala
approved these changes
Apr 8, 2021
Contributor
asheemmamoowala
left a comment
asheemmamoowala
left a comment
There was a problem hiding this comment.
Thanks for the cleanup and simplification @johanrd !
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inspecting the svgs in
mapbox-gl-draw.cssI saw a huge potential for cleanup and optimizations. The changes in this PR does not cause any visual changes, nor any browser relevant SVG specifications:• Remove geometry outside (!) the viewbox
• Remove unused and unnecessary complex geometry and definitions inside the viewbox
• Optimize geometry representation to compound paths
• Optimize number of decimals from six to one through ImageOptim (lossy, yes, but not noticeable)
• Represent SVGs as SVGs in css, not Base64 encoded SVGs (Base64 encoding of well written SVGs is meaningless – it just increases the file size).