Fix 'simple_select' mode lacking 'touchend' event handling (#684)#1008
Merged
mourner merged 2 commits intomapbox:mainfrom May 19, 2021
Merged
Fix 'simple_select' mode lacking 'touchend' event handling (#684)#1008mourner merged 2 commits intomapbox:mainfrom
mourner merged 2 commits intomapbox:mainfrom
Conversation
corinv
changed the title
|
Would love to see this merged - it seems to fix an issue we're having on touch devices (iPad) where dragging polygon in |
mourner
approved these changes
May 19, 2021
Member
|
Sorry for getting back so late on this, and thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (#684).
The
draw.updateevent would not be fired on moving a geometry using a touch device (or emulated touch, like Chrome's device mode) as there was no handling for atouchendevent to fire said event in thesimple_selectmode.