Skip to content

Eliminate dependence on Map#fire – breaking change in mapbox-gl-js #766

@mollymerp

Description

@mollymerp

mapbox-gl-js recently changed the function signature for fire, so our most recent beta release (mapbox/mapbox-gl-js#6549) breaks compatibility with this library. see change log here https://github.com/mapbox/mapbox-gl-js/releases/tag/v0.45.0-beta.1

mapbox-gl-draw shouldn't be relying on Map#fire because it is not a public method, but if that is impossible, another option would be to call fire with an object that has a type attribute {type: 'error', message: 'somethingbad', //... rest of the payload properties }. We may also consider making the Event class public so third party libraries like this can use that constructor.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugrefactorCode that needs to be updated

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions