Conversation
Closed
mourner
added a commit
that referenced
this pull request
Feb 24, 2015
Accept an option to return indexed vertices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the API to have an option to return indexed vertices. Closes #4. Second attempt after #5.
Indexed result has a performance cost of ~10-20%. Here are some benchmarks:
The configurability is worth it. Whether to use indexed output depends on the application, but we have it off by default.
This also breaks the 3D vertices use cases, we need to think about it API-wise.
cc @ansis @kkaefer