Conversation
this.kx and this.ky are calculated by theoretical first-order approximation
Closed
Contributor
|
@mourner should we merge the PR on the cpp port? |
Member
Author
|
@tmpsantos certainly, but it needs to be updated with new WGS84 parameters (they're commented out there) and updated tests, reflecting this PR. |
dbrgn
added a commit
to dbrgn/flugbuech
that referenced
this pull request
Sep 25, 2020
This contains a change that switches to the WGS84 ellipsoid model of the earth, thus changing the track length very very slightly (but a test needed to be adjusted). See Turbo87/flat-projection-rs#21 and mapbox/cheap-ruler#41 for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes and closes #36. Reasons for the switch are well explained in mapbox/cheap-ruler-cpp#13.